selected rows in list should merge style with inline style #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectedRowStyle should be merged with inline styles. This change does two things: 1. Use ParseStyles for SelectedRowStyle 2. Merge modifiers in readStyle instead of inline styles clearing any default modifiers.
|
Thanks for bringing this up. So I think I intentionally made the colors override instead of merge, but now I'm trying to figure out which is the better solution. I guess it would be good to make that an option for the user? But then we would probably have to add an argument to |
cjbassi
force-pushed
the
master
branch
2 times, most recently
from
32a5f54
to
6d201dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List SelectedRowStyle should be merged with inline styles. This change does two things:
I'm not sure if it was intended for SelectedRowStyle to completely override the inline styles. If it was, please feel free to disregard and reject this pull request 😃